-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make generation of measurements file deterministic #149
base: main
Are you sure you want to change the base?
Conversation
Feel free to undo the use of FastRandom. nextGaussian is a lot of code, hence I prefered to take that all out and also the double to char/byte conversion. There are ways to make that all faster, It is for instance a single thread and also we roll char to byte again and again. |
|
f319d55
to
b8ed3a6
Compare
Updated with the new random station generation. Now we have 3 measurement creators that output the exact same file :P I have also made some slight syntactic changes to the name generation @mtopolnik. Semantically it should do the same thing, but would appreciate if you could take a look either way. |
I bit the bullet and rented out a CCX3 :D Very surprising results using the full 1B dataset on this machine: merykitty - 51 seconds |
Correction: didn't check the command output... obourgain takes 5 seconds to break with OOM :D |
Update: royvanrijn's solution now works. @gunnarmorling I'm wondering if you're having second thoughts on merging this, given the difference in the timings and the large number of contestants. OTOH it's kind of beside the point to reward solutions that work great for 416 short keys but degrade significantly for 10,000 keys using the full 100 byte range. |
…easurements2 produce the same output
Addresses #35.
This is currently not implemented/added for CreateMeasurements2 (@rschwietzke).If it's desirable that both produce the same output, LMK and I can add that.Makes both CreateMeasurement implementations generate the same output, and makes it deterministic based on a provided seed (with a default value).